Add test for AzureRmSqlServerActiveDirectoryAdministrator API#3196
Add test for AzureRmSqlServerActiveDirectoryAdministrator API#3196shahabhijeet merged 23 commits intoAzure:psSdkJson6from
Conversation
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
@jaczhan, |
| Assert.Equal(aadAdmin, getResult.Login); | ||
| Assert.Equal(new Guid("5e90ef3b-9b42-4777-819b-25c36961ea4d"), getResult.Sid); | ||
| Assert.Equal(new Guid("72f988bf-86f1-41af-91ab-2d7cd011db47"), getResult.TenantId); | ||
|
|
There was a problem hiding this comment.
Add a check for list here too?
nathannfan
left a comment
nathannfan
left a comment
There was a problem hiding this comment.
Looks good to me if it passes validation.
| <Service Include="{82a7f48d-3b50-4b1e-b82e-3ada8210c358}" /> | ||
| </ItemGroup> | ||
| <ItemGroup> | ||
| <PackageReference Update="Microsoft.Rest.ClientRuntime.Azure" Version="3.3.5" /> |
There was a problem hiding this comment.
@jaczhan you don't need to add these references, they get implicitly added.
| { | ||
| public class AzureRmSqlServerActiveDirectoryAdministratorTest | ||
| { | ||
| [Fact] |
There was a problem hiding this comment.
@jaczhan please record test using latest nugets (e.g. 1.5.0 version of Resource manager) Currently you are using 1.1.0-preview version of Resource Manager.
All new tests should be using latest version of Resource Manager.
There was a problem hiding this comment.
how do I switch to the latest nugets?
| <TargetFrameworks>net452;netstandard1.4</TargetFrameworks> | ||
| </PropertyGroup> | ||
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.Azure.Management.ResourceManager" Version="1.6.0-preview" /> |
There was a problem hiding this comment.
@jaczhan any reason you need this nuget in your SQL package?
The requirement was only for recording new test, so your other change is all you need.
You don't want additional dependency on your SQL SDK package.
Please revert "this" particular change.
Please keep your other change that you made in the test project (that is what I had asked for)
| </ItemGroup> | ||
| </Project> No newline at end of file | ||
| <ItemGroup> | ||
| <PackageReference Update="Microsoft.Rest.ClientRuntime.Azure.TestFramework" Version="1.6.0" /> |
There was a problem hiding this comment.
@jaczhan you do not need this, this is being added to every project.
Any reason you had to add reference to TestFramework?
You can remove this package reference.
jaczhan
left a comment
jaczhan
left a comment
There was a problem hiding this comment.
remove Resource Manager 1.6
|
@jaczhan add to whitelist |
|
Adding test for Swagger AzureRmSqlServerActiveDirectoryAdministrator |
jaczhan
changed the title
jaczhan
changed the title
jaczhan
left a comment
jaczhan
left a comment
There was a problem hiding this comment.
changes made to fix 1.6 tag
|
We will rerecord the tests separately - #3267 |
|
@jaczhan looks good, as soon as CI passes this can be merged. |
7 participants
This is adding test for new Swagger AzureRmSqlServerActiveDirectoryAdministrator API for ActiveDirectoryOperations include:
Swagger PR at: Azure/azure-rest-api-specs#1203